[webkit-reviews] review denied: [Bug 94810] Vector::shrinkToFit should use realloc when canCopyWithMemcpy is true : [Attachment 160738] the patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Yong Li <yoli at rim.com>'s
request for review:
Bug 94810: Vector::shrinkToFit should use realloc when canCopyWithMemcpy is
true
https://bugs.webkit.org/show_bug.cgi?id=94810

Attachment 160738: the patch
https://bugs.webkit.org/attachment.cgi?id=160738&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
r- because you do not provide any rationale for making the change.

1) Please microbenchmark this to provide numbers for the improvement.
2) Please find what is the memory impact. Exactly how does fastMalloc work with
those Realloc.


> Also StringBuilder/StringImpl is using fastRealloc to shrink memory anyway.

This is pretty much irrelevant. The memory allocated there is small on average
and the lost memory on shrink is at most a little less the size of the useful
payload.