[webkit-reviews] review denied: [Bug 91718] [EFL] Add Web Inspector to EWebLauncher : [Attachment 154491] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 27 18:57:38 PDT 2012
Gyuyoung Kim <gyuyoung.kim at samsung.com> has denied Seokju Kwon
<seokju.kwon at samsung.com>'s request for review:
Bug 91718: [EFL] Add Web Inspector to EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=91718
Attachment 154491: Patch
https://bugs.webkit.org/attachment.cgi?id=154491&action=review
------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=154491&action=review
> Tools/EWebLauncher/main.c:632
> + ELauncher *appBrowser = (ELauncher*) user_data;
Nit: s/(ELauncher*) user_data/(ELauncher *)user_data/g. Fix remained stuff.
> Tools/EWebLauncher/main.c:639
> + ELauncher *appBrowser = (ELauncher*) user_data;
Nit: s/appBrowser/app_browser/g ?
> Tools/EWebLauncher/main.c:640
> + Evas_Object *inspectorView = (Evas_Object*) event_info;
ditto.
More information about the webkit-reviews
mailing list