[webkit-reviews] review denied: [Bug 40272] The 2d.imageData.object.round canvas test is failing : [Attachment 160747] Boundaries and zero tests, Cr Android EWS build fix.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 27 18:22:51 PDT 2012


Benjamin Poulain <benjamin at webkit.org> has denied Dominik Röttsches (drott)
<dominik.rottsches at intel.com>'s request for review:
Bug 40272: The 2d.imageData.object.round canvas test is failing
https://bugs.webkit.org/show_bug.cgi?id=40272

Attachment 160747: Boundaries and zero tests, Cr Android EWS build fix.
https://bugs.webkit.org/attachment.cgi?id=160747&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=160747&action=review


You addressed the spec above + extended the tests.

> Source/WTF/wtf/MathExtras.h:221
> +	   intgr -= ((intgr >> 30) | 1); // 1 with the sign of result, i.e. -1
or 1.

The ">>30" seems incorrect here.
I would think the tests would have catch that. Did you run the test with this
branch or only with the inline asm?


More information about the webkit-reviews mailing list