[webkit-reviews] review granted: [Bug 95156] [V8] ScriptController::matchesCurrentContext duplicates code from ScriptController::currentWorldContext : [Attachment 160865] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Adam Barth
<abarth at webkit.org>'s request for review:
Bug 95156: [V8] ScriptController::matchesCurrentContext duplicates code from
ScriptController::currentWorldContext
https://bugs.webkit.org/show_bug.cgi?id=95156

Attachment 160865: Patch
https://bugs.webkit.org/attachment.cgi?id=160865&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=160865&action=review


> Source/WebCore/bindings/v8/ScriptController.cpp:447
> +    return v8::Context::GetCurrent() == contextForCurrentWorldPrivate();

CodeGeneratorV8.pm is the only caller site of matchesCurrentContext(). You
might want to write this in CodeGeneratorV8.pm and remove
matchesCurrentContext().