[webkit-reviews] review granted: [Bug 93401] Remove uses of ClassInfo in StrictEq and CompareEq in the DFG : [Attachment 160839] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 93401: Remove uses of ClassInfo in StrictEq and CompareEq in the DFG
https://bugs.webkit.org/show_bug.cgi?id=93401

Attachment 160839: Patch
https://bugs.webkit.org/attachment.cgi?id=160839&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=160839&action=review


R=me but fix the thingies.  You know what to do!

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:1194
> +	       if (at(node.child1()).shouldSpeculateCell() &&
at(node.child2()).shouldSpeculateFinalObjectOrOther())

You missed a thingy.

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:1198
> +	       else if (at(node.child1()).shouldSpeculateCell() &&
at(node.child2()).shouldSpeculateCell())

You missed a thingy.

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:2922
> +	   if (at(node.child1()).shouldSpeculateCell() &&
at(node.child2()).shouldSpeculateFinalObjectOrOther()) {

You missed a thingy.

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:2927
> +	   if (at(node.child1()).shouldSpeculateFinalObjectOrOther() &&
at(node.child2()).shouldSpeculateCell()) {

You missed a thingy.

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:2932
> +	   if (at(node.child1()).shouldSpeculateCell() &&
at(node.child2()).shouldSpeculateCell()) {

Thingy!

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:3068
> +    if (at(node.child1()).shouldSpeculateCell() &&
at(node.child2()).shouldSpeculateCell()) {

Thingy.