[webkit-reviews] review requested: [Bug 95002] Crash when same SVG used as a CSS background AND drawn on canvas : [Attachment 160830] Use SVGImage instead of cached image when drawing without a render tree.

[bugzilla-daemon at webkit.org]

Philip Rogers <pdr at google.com> has asked  for review:
Bug 95002: Crash when same SVG used as a CSS background AND drawn on canvas
https://bugs.webkit.org/show_bug.cgi?id=95002

Attachment 160830: Use SVGImage instead of cached image when drawing without a
render tree.
https://bugs.webkit.org/attachment.cgi?id=160830&action=review

------- Additional Comments from Philip Rogers <pdr at google.com>
Requesting a review from Nikolas on this one... I'm just getting into this code
and this patch relies on a codepath that you removed from your haromize patch:

inline Image* CachedImage::lookupOrCreateImageForRenderer(const RenderObject*
renderer)
{
...
    Image* useImage =
m_svgImageCache->lookupOrCreateBitmapImageForRenderer(renderer);
    if (useImage == Image::nullImage())
	return m_image.get();
...

My understanding is that we should fall back to using SVGImage (aka
m_image.get()) when we aren't in the render tree (and don't have a cached
image). This means, to draw we just rely on SVGImage::draw().