[webkit-reviews] review requested: [Bug 94993] RenderLayerBacking::startAnimation() return value has incorrect semantics : [Attachment 160815] Patch with layout test

[bugzilla-daemon at webkit.org]

Shawn Singh <shawnsingh at chromium.org> has asked  for review:
Bug 94993: RenderLayerBacking::startAnimation() return value has incorrect
semantics
https://bugs.webkit.org/show_bug.cgi?id=94993

Attachment 160815: Patch with layout test
https://bugs.webkit.org/attachment.cgi?id=160815&action=review

------- Additional Comments from Shawn Singh <shawnsingh at chromium.org>
Dear Reviewers, the provided layout test is fully correct, however, it does not
actually reproduce the original bug until accelerated animations are enabled
for chromium port of DumpRenderTree. For Safari, the original bug does not
occur until I programmatically forced big rotations to be rejected (by
commenting out the PlatformCAAnimation::supportsValueFunction() in
GraphicsLayerCA.cpp:1874). For Chrome, the bug reproduces in the new layout
test when checking manually, and when accelerated animations for DRT are
enabled, this test will be the correct scenario.  I also tested locally on
Safari and Chrome layout tests, no obvious regressions, and it passes unit
tests and manual testing.  With your approval I would like to go ahead and land
this patch, because it will unfortunately be some time more before accelerated
animations are enabled for chromium DRT.