[webkit-reviews] review granted: [Bug 94941] Web Inspector: [WebGL] Add a test to catch new WebGL context states parameters : [Attachment 160716] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Andrey Adaikin
<aandrey at chromium.org>'s request for review:
Bug 94941: Web Inspector: [WebGL] Add a test to catch new WebGL context states
parameters
https://bugs.webkit.org/show_bug.cgi?id=94941

Attachment 160716: Patch
https://bugs.webkit.org/attachment.cgi?id=160716&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
Looks fine -- but I don't think this test will catch any new additions to the
spec. It's very unlikely that any of these state variables will be removed from
future versions of the OpenGL ES (and therefore WebGL) spec. All that is likely
to happen is that new state variables will be added -- and this test won't
catch those. Probably the only way of doing so would be to enumerate all
properties on the WebGLRenderingContext, remove those you know about, and see
if there are any left. I think there is already such a test in the WebGL
conformance suite; see http://www.khronos.org/webgl/wiki/Testing/Conformance .