[webkit-reviews] review granted: [Bug 95118] Hook procedure should check to see if hook has already been removed before attempting removal. : [Attachment 160798] typo in Changelog

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 27 13:55:25 PDT 2012


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Roger Fong
<roger_fong at apple.com>'s request for review:
Bug 95118: Hook procedure should check to see if hook has already been removed
before attempting removal.
https://bugs.webkit.org/show_bug.cgi?id=95118

Attachment 160798: typo in Changelog
https://bugs.webkit.org/attachment.cgi?id=160798&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=160798&action=review


> Source/WebCore/ChangeLog:8
> +	   Sometimes, the hook procedure can passed to another hook procedure
that can dispatch another message. 

"can passed to"?

> Source/WebCore/ChangeLog:9
> +	   This message goes back through the hook chain and causes the
hookFired method to get called again 

Are you saying that it can re-enter?


More information about the webkit-reviews mailing list