[webkit-reviews] review denied: [Bug 94984] Make RenderBox::computePositionedLogicalHeight const : [Attachment 160762] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 27 11:52:13 PDT 2012


Dave Hyatt <hyatt at apple.com> has denied Tony Chang <tony at chromium.org>'s
request for review:
Bug 94984: Make RenderBox::computePositionedLogicalHeight const
https://bugs.webkit.org/show_bug.cgi?id=94984

Attachment 160762: Patch
https://bugs.webkit.org/attachment.cgi?id=160762&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
We talked about this in IRC. I think we want a separate margin struct, and then
I'd like a single common struct we can use for either width or height that
contains a position, an extent, and the margins.


More information about the webkit-reviews mailing list