[webkit-reviews] review granted: [Bug 94996] [chromium] Clean up dependencies of WebScrollbar and WebScrollbarLayer : [Attachment 160540] Patch

[bugzilla-daemon at webkit.org]

Adrienne Walker <enne at google.com> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 94996: [chromium] Clean up dependencies of WebScrollbar and
WebScrollbarLayer
https://bugs.webkit.org/show_bug.cgi?id=94996

Attachment 160540: Patch
https://bugs.webkit.org/attachment.cgi?id=160540&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=160540&action=review


R=me.  Thanks for taking care of this.

> Source/Platform/chromium/public/WebScrollbarLayer.h:42
> +    // This takes ownership of the provided WebScrollbar.
> +    WEBKIT_EXPORT static WebScrollbarLayer* create(WebScrollbar*,
WebScrollbarThemePainter, PassOwnPtr<WebScrollbarThemeGeometry>);

No need for a comment--make the WebScrollbar a PassOwnPtr too like the
geometry.  It's weird to be inconsistent about ownership transfer.

> Source/WebCore/platform/chromium/support/WebScrollbarImpl.h:38
> +    explicit WebScrollbarImpl(WebCore::Scrollbar*);

Can you add a static create function that returns a PassOwnPtr so you don't
have to adoptPtr it all over the place?