[webkit-reviews] review granted: [Bug 95088] Web Inspector: Debugger should break on failed assertions in Break on exceptions mode. : [Attachment 160723] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 95088: Web Inspector: Debugger should break on failed assertions in Break
on exceptions mode.
https://bugs.webkit.org/show_bug.cgi?id=95088

Attachment 160723: Patch
https://bugs.webkit.org/attachment.cgi?id=160723&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=160723&action=review


> Source/WebCore/inspector/InspectorInstrumentation.cpp:894
> +    if (InspectorDebuggerAgent* debuggerAgent =
instrumentingAgents->inspectorDebuggerAgent())

I would call console agent first in order to have the message appear in the
console before pausing. We had user complains about exceptions being logged
only after you resume.