[webkit-reviews] review granted: [Bug 94696] Web Inspector: [WebGL] Simple experimental frontend implementation : [Attachment 160397] Made it a profile type

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has granted Andrey Adaikin
<aandrey at chromium.org>'s request for review:
Bug 94696: Web Inspector: [WebGL] Simple experimental frontend implementation
https://bugs.webkit.org/show_bug.cgi?id=94696

Attachment 160397: Made it a profile type
https://bugs.webkit.org/attachment.cgi?id=160397&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=160397&action=review


> Source/WebCore/inspector/front-end/WebGLProfileView.js:103
> +	       for (var i = 0, n = calls.length; i < n; ++i) {

for (var i = 0; i < calls.length; ++i) ?

> Source/WebCore/inspector/front-end/WebGLProfileView.js:105
> +		   var elm = document.createElement("div");

traceLogItem

> Source/WebCore/inspector/front-end/WebGLProfileView.js:121
> +	   function didReplayTraceLog(error, dataUrl)

dataURL