[webkit-reviews] review granted: [Bug 94806] [GStreamer][Qt] WebAudio support : [Attachment 160708] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 94806: [GStreamer][Qt] WebAudio support
https://bugs.webkit.org/show_bug.cgi?id=94806

Attachment 160708: Patch
https://bugs.webkit.org/attachment.cgi?id=160708&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=160708&action=review


> Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:31
> +#if PLATFORM(QT)
> +// Clear out offending Qt macro so the following header, gio.h, can be
included.
> +#undef signals
> +#endif

I think that's okay for the moment. It would be great if you could file a bug
report and assign it to me to fix this and maybe add a link to it in a comment.
But either way this can be fixed at a later point.