[webkit-reviews] review granted: [Bug 95065] Web Inspector: DOM tree search issue with quotation marks : [Attachment 160688] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 27 04:46:28 PDT 2012


Pavel Feldman <pfeldman at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 95065: Web Inspector: DOM tree search issue with quotation marks
https://bugs.webkit.org/show_bug.cgi?id=95065

Attachment 160688: Patch
https://bugs.webkit.org/attachment.cgi?id=160688&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=160688&action=review


> Source/WebCore/inspector/InspectorDOMAgent.cpp:861
> +		       if (!exactAttributeMatch &&
attribute->localName().find(attributeQuery) != notFound) {

Why did this change? I wonder if we could support the 'class="foo' or
'width=100%' case here.


More information about the webkit-reviews mailing list