[webkit-reviews] review granted: [Bug 94923] Web Inspector: Incorrect property override computation when !important is involved : [Attachment 160670] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 27 02:32:46 PDT 2012
Vsevolod Vlasov <vsevik at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 94923: Web Inspector: Incorrect property override computation when
!important is involved
https://bugs.webkit.org/show_bug.cgi?id=94923
Attachment 160670: Patch
https://bugs.webkit.org/attachment.cgi?id=160670&action=review
------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=160670&action=review
> Source/WebCore/inspector/front-end/StylesSidebarPane.js:528
> + // No need to check any further if we know an !important
value has already been seen.
I don't think this comment is needed.
> Source/WebCore/inspector/front-end/StylesSidebarPane.js:534
> + // Property is not important in this rule and has
encountered earlier - do nothing.
I don't think this comment is needed.
More information about the webkit-reviews
mailing list