[webkit-reviews] review canceled: [Bug 72811] [Gtk] No accessible caret-moved events found in certain content : [Attachment 160549] proposed fix - part 2 (master compatible AND with new tests git-added)

[bugzilla-daemon at webkit.org]

Joanmarie Diggs <jdiggs at igalia.com> has canceled Joanmarie Diggs
<jdiggs at igalia.com>'s request for review:
Bug 72811: [Gtk] No accessible caret-moved events found in certain content
https://bugs.webkit.org/show_bug.cgi?id=72811

Attachment 160549: proposed fix - part 2 (master compatible AND with new tests
git-added)
https://bugs.webkit.org/attachment.cgi?id=160549&action=review

------- Additional Comments from Joanmarie Diggs <jdiggs at igalia.com>
(In reply to comment #33)
> (From update of attachment 160549 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=160549&action=review
> 
> > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1956
> > +	 if (node && node->hasTagName(spanTag))
> 
> we should have a comment here as to why all span tags need to be ignored

Done.