[webkit-reviews] review granted: [Bug 95049] [Chromium-Android] Move webkit_unit_tests_apk and TestWebKitAPI_apk into condition block [gtest_target_type == "shared_library"' : [Attachment 160648] patch v1

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Johnny(Jianning) Ding
<jnd at chromium.org>'s request for review:
Bug 95049: [Chromium-Android] Move webkit_unit_tests_apk and TestWebKitAPI_apk
into condition block [gtest_target_type == "shared_library"'
https://bugs.webkit.org/show_bug.cgi?id=95049

Attachment 160648: patch v1
https://bugs.webkit.org/attachment.cgi?id=160648&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=160648&action=review


> Source/WebKit/chromium/ChangeLog:9
> +	   Move webkit_unit_tests_apk and TestWebKitAPI_apk into block of
gtest_target_type == "shared_library"

Ideally, the ChangeLog would include the "why" behind the change.  You've
explained the why in Comment #0.  You might just want to copy it into the
ChangeLog.