[webkit-reviews] review granted: [Bug 95045] Initialized m_hasNonEmptyList to fix a valgrind uninitialized read : [Attachment 160637] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 26 22:40:12 PDT 2012


Kent Tamura <tkent at chromium.org> has granted Nico Weber <thakis at chromium.org>'s
request for review:
Bug 95045: Initialized m_hasNonEmptyList to fix a valgrind uninitialized read
https://bugs.webkit.org/show_bug.cgi?id=95045

Attachment 160637: Patch
https://bugs.webkit.org/attachment.cgi?id=160637&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=160637&action=review


> Source/WebCore/html/HTMLInputElement.cpp:1529
> +#if ENABLE(DATALIST_ELEMENT)
>      if (!m_hasNonEmptyList)
>	   return 0;
> +#endif

You don't need to add #if ENABLE(DATALIST_ELEMENT) because
HTMLInputElement::dataList() is in #if ENABLE_DATALIST_ELEMENT).


More information about the webkit-reviews mailing list