[webkit-reviews] review granted: [Bug 94926] Remove parent pointer from StyleSheetInternal and StyleRuleImport : [Attachment 160612] with less (?) bugs

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 94926: Remove parent pointer from StyleSheetInternal and StyleRuleImport
https://bugs.webkit.org/show_bug.cgi?id=94926

Attachment 160612: with less (?) bugs
https://bugs.webkit.org/attachment.cgi?id=160612&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=160612&action=review


r=me

> Source/WebCore/css/StyleRuleImport.h:-59
> -    // NOTE: We put the CachedStyleSheetClient in a member instead of
inheriting from it
> -    // to avoid adding a vptr to StyleRuleImport.
> -    class ImportedStyleSheetClient : public CachedStyleSheetClient {

Glad to see this hack disappear!

> Source/WebCore/css/StyleSheetContents.cpp:340
> +	       m_didLoadErrorOccur = true;

Sidenote: m_didLoadErrorOccur is a pretty awkward variable name.