[webkit-reviews] review granted: [Bug 95036] Prerenderering should gracefully handle no PrerendererClient or PrerenderingPlatform being provided. : [Attachment 160610] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Gavin Peters <gavinp at chromium.org>'s
request for review:
Bug 95036: Prerenderering should gracefully handle no PrerendererClient or
PrerenderingPlatform being provided.
https://bugs.webkit.org/show_bug.cgi?id=95036

Attachment 160610: Patch
https://bugs.webkit.org/attachment.cgi?id=160610&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=160610&action=review


> Source/WebCore/loader/Prerenderer.cpp:140
> -    if (!m_client)
> +    if (!m_initializedClient) {
> +	   m_initializedClient = true;
>	   m_client = PrerendererClient::from(document()->page());
> +    }
>      return m_client;

Should we just do this in the constructor?  I don't remember the exactly access
sequence for these objects.