[webkit-reviews] review granted: [Bug 94940] Web Inspector: make ConsoleView listen to the JavaScriptContextManager : [Attachment 160435] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 94940: Web Inspector: make ConsoleView listen to the
JavaScriptContextManager
https://bugs.webkit.org/show_bug.cgi?id=94940

Attachment 160435: Patch
https://bugs.webkit.org/attachment.cgi?id=160435&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=160435&action=review


> Source/WebCore/inspector/front-end/JavaScriptContextManager.js:56
> +	   var result = [];

We now have Object.values(this._frameIdToContext)

> Source/WebCore/inspector/front-end/ParsedURL.js:-101
> -	   if (trimmedHref.startsWith("data:") ||
trimmedHref.startsWith("blob:"))

Please mention this drive by in the changelog.