[webkit-reviews] review denied: [Bug 93551] Some CSS pseudo selectors causing clicks to reload resources on input with type=image : [Attachment 160078] Patch

[bugzilla-daemon at webkit.org]

Maciej Stachowiak <mjs at apple.com> has denied Pravin D <pravind.2k4 at gmail.com>'s
request for review:
Bug 93551: Some CSS pseudo selectors causing clicks to reload resources on
input with type=image
https://bugs.webkit.org/show_bug.cgi?id=93551

Attachment 160078: Patch
https://bugs.webkit.org/attachment.cgi?id=160078&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
This change looks wrong. It looks like it will still call
m_imageLoader->updateFromElement unnecessarily in other cases. It also makes
the logic hard to follow. Instead of this, you should look at what
HTMLImageElement does. It does not call updateFromElement() in attach() at all,
only when setting the src attribute or when inserting into document, and then
only if the image loader had not loaded an image already. That is much better
than the somewhat kludgey change here.