[webkit-reviews] review granted: [Bug 94897] Don't use malloc / destructors for activation objects : [Attachment 160554] Patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Geoffrey Garen <ggaren at apple.com>'s
request for review:
Bug 94897: Don't use malloc / destructors for activation objects
https://bugs.webkit.org/show_bug.cgi?id=94897

Attachment 160554: Patch
https://bugs.webkit.org/attachment.cgi?id=160554&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=160554&action=review


r+ if you can answer/correct the commented code

> Source/JavaScriptCore/runtime/JSStaticScopeObject.cpp:45
> -    visitor.append(&thisObject->m_registerStore);
> +    if (thisObject->m_registerStore)
> +	   visitor.append(&thisObject->m_registerStore);

you don't need this change

> Source/JavaScriptCore/runtime/JSSymbolTableObject.cpp:45
> +    JSNonFinalObject::visitChildren(thisObject, visitor);

Should be Base::visitChildren unless you have a compelling reason not to

> Source/JavaScriptCore/runtime/JSSymbolTableObject.cpp:46
> +    if (thisObject->m_symbolTable)

null check is unnecessary here

> Source/JavaScriptCore/runtime/SymbolTable.cpp:47
> +    SharedSymbolTable* thisObject = static_cast<SharedSymbolTable*>(cell);

jsCast<>