[webkit-reviews] review granted: [Bug 94859] [chromium] Prevent scrollbar thumb size from changing during compositor zoom : [Attachment 160517] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Adrienne Walker
<enne at google.com>'s request for review:
Bug 94859: [chromium] Prevent scrollbar thumb size from changing during
compositor zoom
https://bugs.webkit.org/show_bug.cgi?id=94859

Attachment 160517: Patch
https://bugs.webkit.org/attachment.cgi?id=160517&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=160517&action=review


R=me. seems like the most reasonable solution to a not very reasonable problem

> Source/WebKit/chromium/ChangeLog:12
> +2012-08-23  Adrienne Walker	<enne at google.com>

you've got a double changelog somehow

>
Source/WebCore/platform/graphics/chromium/cc/CCScrollbarGeometryFixedThumb.cpp:
80
> +	   return (pos < 1 && pos > 0) ? 1 : pos;

would you mind being a little about how you want the type conversion to happen
on the return here? i.e. floorf() before the cast if floor is what we want?

>
Source/WebCore/platform/graphics/chromium/cc/CCScrollbarGeometryFixedThumb.h:52

> +   
CCScrollbarGeometryFixedThumb(PassOwnPtr<WebKit::WebScrollbarThemeGeometry>);

guess what!

> Source/WebCore/platform/graphics/chromium/cc/CCScrollbarGeometryStub.h:64
> +    CCScrollbarGeometryStub(PassOwnPtr<WebKit::WebScrollbarThemeGeometry>);

and again