[webkit-reviews] review granted: [Bug 90046] Implement sticky positioning : [Attachment 160533] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 90046: Implement sticky positioning
https://bugs.webkit.org/show_bug.cgi?id=90046

Attachment 160533: Patch
https://bugs.webkit.org/attachment.cgi?id=160533&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=160533&action=review


> Source/WebCore/rendering/RenderBoxModelObject.cpp:563
> +    // Have to recompute the margins, because the already-computed margins
include extra space.

This comment is still needlessly vague IMO since it's really just auto-margins
that are being special handled here. I'd still prefer the code below to special
case auto as I suggested in the previous review, but that's up to you.

> Source/WebCore/rendering/RenderBoxModelObject.cpp:585
> +

Mind adding a FIXME that this should be reordered in order to match the
position:relative behavior when both top and bottom or left and right are
specified?

> Source/WebCore/rendering/RenderLayer.h:571
> +	   HasSeenFixedOrStickyAncestor = 1 << 0,

HasSeenViewportConstrainedAncestor maybe?