[webkit-reviews] review denied: [Bug 94649] Populate DatabaseTracker's origins lazily on demand : [Attachment 159806] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 24 14:22:02 PDT 2012


Brady Eidson <beidson at apple.com> has denied Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 94649: Populate DatabaseTracker's origins lazily on demand
https://bugs.webkit.org/show_bug.cgi?id=94649

Attachment 159806: Patch
https://bugs.webkit.org/attachment.cgi?id=159806&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
I would like to see populateOrigins() renamed to populateOriginsIfNeeded() to
make it clear to readers of the individual functions that there's no recurring
side effect or cost.


More information about the webkit-reviews mailing list