[webkit-reviews] review granted: [Bug 90046] Implement sticky positioning : [Attachment 160291] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 90046: Implement sticky positioning
https://bugs.webkit.org/show_bug.cgi?id=90046

Attachment 160291: Patch
https://bugs.webkit.org/attachment.cgi?id=160291&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=160291&action=review


r=me

> Source/WebCore/rendering/RenderBoxModelObject.cpp:548
> +	       if (offsetParent->isBox() && offsetParent->isBody() &&
!offsetParent->isInFlowPositioned() && !offsetParent->isOutOfFlowPositioned())

Maybe add an isPositioned method that includes both out of flow and in flow?
Then you could just say && !offsetParent->isPositioned() here.

> Source/WebCore/rendering/RenderBoxModelObject.cpp:586
> +    // Horizontal postion.

Typo. "position"