[webkit-reviews] review granted: [Bug 91117] Add support for compositing the contents of overflow:scroll areas : [Attachment 160192] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Sami Kyöstilä
<skyostil at chromium.org>'s request for review:
Bug 91117: Add support for compositing the contents of overflow:scroll areas
https://bugs.webkit.org/show_bug.cgi?id=91117

Attachment 160192: Patch
https://bugs.webkit.org/attachment.cgi?id=160192&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=160192&action=review


> Source/WebCore/rendering/RenderLayerBacking.cpp:537
> +    if (compAncestor &&  compAncestor->usesCompositedScrolling()) {

Two spaces here after the &&

> Source/WebCore/rendering/RenderLayerBacking.cpp:730
> +	   // We don't have to consider overflow controls, because we know that
the scrollbars are drawn elsewhere.

This comment may not be appropriate on desktop, but let's fix this later.