[webkit-reviews] review denied: [Bug 94947] Web Inspector: do not count weak and shortcut edges when calculating distance to window : [Attachment 160439] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 24 09:58:02 PDT 2012


Yury Semikhatsky <yurys at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 94947: Web Inspector: do not count weak and shortcut edges when calculating
distance to window
https://bugs.webkit.org/show_bug.cgi?id=94947

Attachment 160439: Patch
https://bugs.webkit.org/attachment.cgi?id=160439&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=160439&action=review


> Source/WebCore/inspector/front-end/HeapSnapshot.js:958
> +		   var edgeType = containmentEdges[edgeToNodeIndex -
edgeToNodeOffset + edgeTypeOffset];

This looks ugly. Let's iterate over edgeIndexes and add appropriate offsets
instead of first adding and then subtracting the offsets.


More information about the webkit-reviews mailing list