[webkit-reviews] review denied: [Bug 91487] AuthorShadowDOM for select element : [Attachment 160311] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 24 09:23:13 PDT 2012


Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 91487: AuthorShadowDOM for select element
https://bugs.webkit.org/show_bug.cgi?id=91487

Attachment 160311: Patch
https://bugs.webkit.org/attachment.cgi?id=160311&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
The changing of the RenderObject type when adding a new shadow root is
unsettling and I am hoping we'll come up with a better way to do this.

However, this patch already has several bits that look like good refactoring
improvements.


More information about the webkit-reviews mailing list