[webkit-reviews] review granted: [Bug 94933] Web Inspector: [WebGL] Implement serializing WebGL state and replaying it later : [Attachment 160417] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Andrey Adaikin
<aandrey at chromium.org>'s request for review:
Bug 94933: Web Inspector: [WebGL] Implement serializing WebGL state and
replaying it later
https://bugs.webkit.org/show_bug.cgi?id=94933

Attachment 160417: Patch
https://bugs.webkit.org/attachment.cgi?id=160417&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=160417&action=review


> Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js:257
> +	   var thisObject = /** @type {ReplayableResource} */
(Resource.toReplayable(this._thisObject, cache));

No need for ( ) in case of assignment cast.

> Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js:678
> +    /** @inheritDoc */

We don't use @inheritDoc

> Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js:782
> +	       switch (uniform.type) {

You could use a map here.

> Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js:783
> +		   case gl.FLOAT:

Do not indent case

> Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js:979
> +    "ACTIVE_TEXTURE",

We need to add a test so that we could track changes to this set.