[webkit-reviews] review denied: [Bug 94849] [GTK] Compiling with --disable-blob fails with undefined symbol : [Attachment 160238] Patch that fixes the problem

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 24 08:11:02 PDT 2012


Xan Lopez <xan.lopez at gmail.com> has denied Philip Chimento
<philip.chimento at gmail.com>'s request for review:
Bug 94849: [GTK] Compiling with --disable-blob fails with undefined symbol
https://bugs.webkit.org/show_bug.cgi?id=94849

Attachment 160238: Patch that fixes the problem
https://bugs.webkit.org/attachment.cgi?id=160238&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
r- per previous comment. Basically I think this should take into account the
ENABLE features in WebKit (see how the bindings are generated), but the compat.
method should always be present to not break API (and thus, the WebKitDOMBlob
type should always be present too). I believe this is how we do the other
stuff.


More information about the webkit-reviews mailing list