[webkit-reviews] review granted: [Bug 94799] Web Inspector: [WebGL] Implement custom wrap functions on GL context : [Attachment 160132] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 24 04:39:16 PDT 2012


Pavel Feldman <pfeldman at chromium.org> has granted Andrey Adaikin
<aandrey at chromium.org>'s request for review:
Bug 94799: Web Inspector: [WebGL] Implement custom wrap functions on GL context
https://bugs.webkit.org/show_bug.cgi?id=94799

Attachment 160132: Patch
https://bugs.webkit.org/attachment.cgi?id=160132&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=160132&action=review


> Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js:884
> +    "createBuffer": WebGLBufferResource,

I would implement this as array of pairs (arrays) so that you did not need to
use Object.keys.


More information about the webkit-reviews mailing list