[webkit-reviews] review granted: [Bug 93755] ShadowRoot insertion point change aborts css transition : [Attachment 160341] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 24 02:16:00 PDT 2012
Hajime Morrita <morrita at google.com> has granted Takashi Sakamoto
<tasak at google.com>'s request for review:
Bug 93755: ShadowRoot insertion point change aborts css transition
https://bugs.webkit.org/show_bug.cgi?id=93755
Attachment 160341: Patch
https://bugs.webkit.org/attachment.cgi?id=160341&action=review
------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=160341&action=review
Looks much better now.
> Source/WebCore/ChangeLog:8
> + ElementShadow always detach shadow hosts when distribution is
s/detach/detaches/
> Source/WebCore/ChangeLog:13
> + distribution, should not make shadow host reattach. Instead, should
s/should/it should/
> Source/WebCore/ChangeLog:14
> + make distribute nodes reattach and set needsRecalcStyle flag of
shadow
s/reattach/reattached/
> Source/WebCore/ChangeLog:21
> + To support replace elements, i.e. IMG, and so on, shadow host's
s/replace/replaced/
More information about the webkit-reviews
mailing list