[webkit-reviews] review denied: [Bug 89666] [Qt] Separate WebKit2 instances use the same local storage : [Attachment 157992] patch for ews
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 23 23:13:57 PDT 2012
Simon Hausmann <hausmann at webkit.org> has denied Szilard Ledan
<szledan at inf.u-szeged.hu>'s request for review:
Bug 89666: [Qt] Separate WebKit2 instances use the same local storage
https://bugs.webkit.org/show_bug.cgi?id=89666
Attachment 157992: patch for ews
https://bugs.webkit.org/attachment.cgi?id=157992&action=review
------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=157992&action=review
This patch is missing a ChangeLog, which I suppose would provide an explanation
as to why these changes are submitted? :)
I'm particularly curious why the disk cache directory needs to be per DRT/WTR
instance.
> Source/WebKit2/UIProcess/mac/WebContextMac.mm:-95
> - ASSERT(!parameters.nsURLCachePath.isEmpty());
Technically this ASSERT should move somewhere else, shouldn't it?
> Tools/WebKitTestRunner/TestController.cpp:320
> + WKContextSetDatabaseDirectory(m_context.get(),
WKStringCreateWithUTF8CString(dumpRenderTreeTemp));
> + WKContextSetLocalStorageDirectory(m_context.get(),
WKStringCreateWithUTF8CString(dumpRenderTreeTemp));
> + WKContextSetDiskCacheDirectory(m_context.get(),
WKStringCreateWithUTF8CString(dumpRenderTreeTemp));
I think you need to store the strings created by WKStringCreate* in a RetainPtr
to avoid them leaking.
More information about the webkit-reviews
mailing list