[webkit-reviews] review denied: [Bug 93401] Remove uses of ClassInfo in StrictEq and CompareEq in the DFG : [Attachment 160329] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has denied Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 93401: Remove uses of ClassInfo in StrictEq and CompareEq in the DFG
https://bugs.webkit.org/show_bug.cgi?id=93401

Attachment 160329: Patch
https://bugs.webkit.org/attachment.cgi?id=160329&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=160329&action=review


> Source/JavaScriptCore/dfg/DFGAbstractState.cpp:763
> +		   forNode(node.child2()).filter(SpecCell | ~SpecString);

Isn't SpecCell | ~SpecString = everything?

As in:

SpecCell = the set of all possible cells
SpecString = the set of all possible strings.  note, SpecString is a subset of
SpecCell
~SpecString = the set of all possible values minus the set of all strings.

Therefore, SpecCell | ~SpecString is the set of all possible values.

I'm pretty sure you meant something different here. ;-)