[webkit-reviews] review canceled: [Bug 94889] Remove the now-unneeded invalidations in RenderTable::removeCaption : [Attachment 160308] Proposed code removal.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 23 21:19:48 PDT 2012


Abhishek Arya <inferno at chromium.org> has canceled Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 94889: Remove the now-unneeded invalidations in RenderTable::removeCaption
https://bugs.webkit.org/show_bug.cgi?id=94889

Attachment 160308: Proposed code removal.
https://bugs.webkit.org/attachment.cgi?id=160308&action=review

------- Additional Comments from Abhishek Arya <inferno at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=160308&action=review


> Source/WebCore/rendering/RenderTable.cpp:-209
> -	   node()->setNeedsStyleRecalc();

Can you please explain in a little more detail why this change is not necessary
now ?

> Source/WebCore/rendering/RenderTable.cpp:-211
> -    setNeedsSectionRecalc();

Good change to remove setNeedsSectionRecalc() here, but this is incomplete
without removing the m_captions manipulation in recalcsections. recalcsections
shouldn't be worrying about captions.


More information about the webkit-reviews mailing list