[webkit-reviews] review granted: [Bug 94865] [Chromium-Android] Many 'Unexpected EOF ...' when a test crashes : [Attachment 160271] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted Xianzhu Wang
<wangxianzhu at chromium.org>'s request for review:
Bug 94865: [Chromium-Android] Many 'Unexpected EOF ...' when a test crashes
https://bugs.webkit.org/show_bug.cgi?id=94865

Attachment 160271: Patch
https://bugs.webkit.org/attachment.cgi?id=160271&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=160271&action=review


Ah, I knew the android port depended on this somehow but I didn't connect the
dots to realize that adb was still running. Sorry about that!

> Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:143
> +					   universal_newlines=True,
treat_no_data_as_crash=True)

why not just make this a method on the port class?