[webkit-reviews] review denied: [Bug 94890] REGRESSION(r126132): thumb doesn't match click position for rtl input type=range : [Attachment 160314] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 94890: REGRESSION(r126132): thumb doesn't match click position for rtl
input type=range
https://bugs.webkit.org/show_bug.cgi?id=94890

Attachment 160314: Patch
https://bugs.webkit.org/attachment.cgi?id=160314&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=160314&action=review


> Source/WebCore/ChangeLog:3
> +	   thumb doesn't match click position for rtl input type=range

Please follow our notation for a regression bug. 
REGRESSION(revision): description

> Source/WebCore/html/shadow/SliderThumbElement.cpp:279
> +	   if (!renderBox()->style()->isLeftToRightDirection())

"renderBox()->style()->isLeftToRightDirection()" appears three times in this
function. We had better holding it in a local variable.