[webkit-reviews] review granted: [Bug 94892] [chromium] Fix lost context when textures are evicted : [Attachment 160313] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Antoine Labour
<piman at chromium.org>'s request for review:
Bug 94892: [chromium] Fix lost context when textures are evicted
https://bugs.webkit.org/show_bug.cgi?id=94892

Attachment 160313: Patch
https://bugs.webkit.org/attachment.cgi?id=160313&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=160313&action=review


R=me. I wish this didn't keep breaking :/

> Source/WebCore/ChangeLog:3
> +	   [chromium] Fix lost context when textures are evicted

ambitious title :)

> Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp:33
> +#include "CCSingleThreadProxy.h"

hmm, need this just for DebugScoped...? we don't do a good job of putting
utility things in good headers - I should go move some of these out into better
places

> Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp:2651
> +    virtual void didCommitAndDrawFrame()

OVERRIDE on this and the others please (got bit today trying to refactor some
tests :/)