[webkit-reviews] review denied: [Bug 94664] [Forms] Step mismatched value should be editable in multiple field time UI. : [Attachment 159866] Patch 1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 23 18:59:31 PDT 2012
Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 94664: [Forms] Step mismatched value should be editable in multiple field
time UI.
https://bugs.webkit.org/show_bug.cgi?id=94664
Attachment 159866: Patch 1
https://bugs.webkit.org/attachment.cgi?id=159866&action=review
------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=159866&action=review
The code change looks ok.
We need another test:
1. Render <input type=time step=60>
2. Sets value as "23:59:59.999" by JavaScript
3. Confirms that additional sub-fields are added to the input.
> Source/WebCore/ChangeLog:8
> + This patch changeds layout method of multiple field time input UI to
changeds -> changes
More information about the webkit-reviews
mailing list