[webkit-reviews] review denied: [Bug 94802] successCallback of ResolveLocalFileSystemURL should not be optional. : [Attachment 160149] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Taiju Tsuiki <tzik at chromium.org>'s
request for review:
Bug 94802: successCallback of ResolveLocalFileSystemURL should not be optional.
https://bugs.webkit.org/show_bug.cgi?id=94802

Attachment 160149: Patch
https://bugs.webkit.org/attachment.cgi?id=160149&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=160149&action=review


> LayoutTests/ChangeLog:11
> +	   * fast/filesystem/filesystem-no-callback-null-ptr-crash.html:

This test is for a crash with a particular scenario. We should have another
conformance test for existence of the successCallback argument.

> LayoutTests/fast/filesystem/filesystem-no-callback-null-ptr-crash.html:19
> -	 webkitResolveLocalFileSystemURL('');
>	 try {
> -	     webkitRequestFileSystem(TEMPORARY, 100);
> -	 }
> +	     webkitResolveLocalFileSystemURL('');
>	 catch(e) {
> -	     document.getElementById('log').innerHTML = "PASS";
> +	     try {
> +		 webkitRequestFileSystem(TEMPORARY, 100);
> +	     }
> +	     catch(e) {
> +		 document.getElementById('log').innerHTML = "PASS";
> +	     }

This looks to change the testing scenario.