[webkit-reviews] review requested: [Bug 89259] [CSS Exclusions] Enable shape-inside for simple rectangles : [Attachment 160293] Incorporating feedback
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 23 17:36:18 PDT 2012
Bear Travis <betravis at adobe.com> has asked for review:
Bug 89259: [CSS Exclusions] Enable shape-inside for simple rectangles
https://bugs.webkit.org/show_bug.cgi?id=89259
Attachment 160293: Incorporating feedback
https://bugs.webkit.org/attachment.cgi?id=160293&action=review
------- Additional Comments from Bear Travis <betravis at adobe.com>
Making suggested changes. All changes have been incorporated with the following
exceptions. Certain areas of the pbx project are not alphabetized by filename
(but by hash), so not all references were alphabetized. The 'ForRenderBlock'
methods are keeping their names, but one is changing to
'isWrapSHapeInfoEnabledForRenderBlock'. Some test cases have hit a null
block->style() reference, so the check is remaining in place. Each LineWidth
should only refer to a single segment, so I left updateAvailableWidth as is.
More information about the webkit-reviews
mailing list