[webkit-reviews] review granted: [Bug 94068] [chromium] Convert WebAnimationCurve subtypes into pure virtual : [Attachment 160286] make non-ownership-transfer functions take const refs

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 23 17:24:54 PDT 2012


Adrienne Walker <enne at google.com> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 94068: [chromium] Convert WebAnimationCurve subtypes into pure virtual
https://bugs.webkit.org/show_bug.cgi?id=94068

Attachment 160286: make non-ownership-transfer functions take const refs
https://bugs.webkit.org/attachment.cgi?id=160286&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=160286&action=review


R=me.

> Source/WebKit/chromium/src/WebAnimationImpl.h:41
> +    explicit WebAnimationImpl(const WebAnimationCurve&, int animationId, int
groupId, TargetProperty);
> +    virtual ~WebAnimationImpl();

s/explicit// >;)


More information about the webkit-reviews mailing list