[webkit-reviews] review granted: [Bug 94869] REGRESSION (r124815): PDF in frame does not display any more : [Attachment 160267] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 23 15:44:43 PDT 2012


Alexey Proskuryakov <ap at webkit.org> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 94869: REGRESSION (r124815): PDF in frame does not display any more
https://bugs.webkit.org/show_bug.cgi?id=94869

Attachment 160267: Patch
https://bugs.webkit.org/attachment.cgi?id=160267&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=160267&action=review


No test?.. <:-|

> Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.mm:345
> +    controller()->didInitializePlugin();

I'm wondering if this should be made async to match regular code path. Probably
not.


More information about the webkit-reviews mailing list