[webkit-reviews] review denied: [Bug 94028] Correct glyph positioning in high-DPI mode without using --enable-text-subpixel-positioning : [Attachment 160249] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Terry Anderson
<tdanderson at chromium.org>'s request for review:
Bug 94028: Correct glyph positioning in high-DPI mode without using
--enable-text-subpixel-positioning
https://bugs.webkit.org/show_bug.cgi?id=94028

Attachment 160249: Patch
https://bugs.webkit.org/attachment.cgi?id=160249&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=160249&action=review


> Source/WebCore/platform/graphics/FontDescription.cpp:39
>      // FXIME: Make them fit into one word.

Nit: May as well fix the FXIME typo while you're here.

> Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp:151
> +float SimpleFontData::platformWidthForGlyph(Glyph glyph, float scaleFactor)
const
>  {
> +    UNUSED_PARAM(scaleFactor);

If you don't name the float, you don't need to use UNUSED_PARAM.

> Source/WebCore/platform/graphics/mac/SimpleFontDataMac.mm:419
> +float SimpleFontData::platformWidthForGlyph(Glyph glyph, float scaleFactor)
const
>  {
> +    UNUSED_PARAM(scaleFactor);

Ditto.

> Source/WebCore/platform/graphics/qt/SimpleFontDataQt.cpp:54
> +float SimpleFontData::platformWidthForGlyph(Glyph glyph, float scaleFactor)
const
>  {
> +    UNUSED_PARAM(scaleFactor);

Ditto.

> Source/WebCore/platform/graphics/win/SimpleFontDataCGWin.cpp:125
> +float SimpleFontData::platformWidthForGlyph(Glyph glyph, float scaleFactor)
const
>  {
> +    UNUSED_PARAM(scaleFactor);

Ditto.