[webkit-reviews] review granted: [Bug 94752] [chromium] Create sharedQuadState at same time as creating quads and give them to the quadSink : [Attachment 160206] Patch

[bugzilla-daemon at webkit.org]

Adrienne Walker <enne at google.com> has granted Dana Jansens
<danakj at chromium.org>'s request for review:
Bug 94752: [chromium] Create sharedQuadState at same time as creating quads and
give them to the quadSink
https://bugs.webkit.org/show_bug.cgi?id=94752

Attachment 160206: Patch
https://bugs.webkit.org/attachment.cgi?id=160206&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=160206&action=review


R=me, with a few nits.

> Source/WebCore/platform/graphics/chromium/cc/CCQuadCuller.cpp:87
> +    ASSERT(passDrawQuad->sharedQuadState() == m_currentSharedQuadState);

Could you also assert here that
m_sharedQuadStateList[passDrawQuad->sharedQuadStateId()] ==
m_currentSharedQuadState and that m_currentSharedQuadState->id() ==
passDrawQuad->sharedQuadStateId()? There's a lot of duplicate state running
around (which I think is necessary), but I just want extra sanity checks that
everything is as expected.

> Source/WebCore/platform/graphics/chromium/cc/CCQuadSink.h:44
> +    virtual CCSharedQuadState*
useSharedQuadState(PassOwnPtr<CCSharedQuadState>) = 0;

Add a comment here describing that this needs to be set prior to calling append
with a quad using it?