[webkit-reviews] review granted: [Bug 94582] [EFL][WK2] Back-forward list API needs extension : [Attachment 160207] patch v3

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Mikhail Pozdnyakov
<mikhail.pozdnyakov at intel.com>'s request for review:
Bug 94582: [EFL][WK2] Back-forward list API needs extension
https://bugs.webkit.org/show_bug.cgi?id=94582

Attachment 160207: patch v3
https://bugs.webkit.org/attachment.cgi?id=160207&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=160207&action=review


> Source/WebKit2/UIProcess/API/efl/ewk_back_forward_list.cpp:147
> +    if (!limit)
> +	   limit = WKBackForwardListGetBackListCount(wkList);

so if you say that you want 0 you get all? Is this how it normally works in EFL
api? if not we should probably use int and return all for negative values.

> Source/WebKit2/UIProcess/API/efl/ewk_back_forward_list.h:59
> + */
> +#define ewk_back_forward_list_back_items_copy(list) \
> +    ewk_back_forward_list_n_back_items_copy(list, 0)
> +
> +/**

why not group this one together with the n_ version?