[webkit-reviews] review denied: [Bug 86022] Refactor layer-related logic out of RenderBoxModelObject : [Attachment 160195] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Florin Malita <fmalita at chromium.org>'s
request for review:
Bug 86022: Refactor layer-related logic out of RenderBoxModelObject
https://bugs.webkit.org/show_bug.cgi?id=86022

Attachment 160195: Patch
https://bugs.webkit.org/attachment.cgi?id=160195&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
I don't really mind the approach taken here, but RenderTransformableObject is
just a terrible terrible name. You picked one aspect of layers (that they
support transforms) and named the entire class after that one feature. That
makes no sense. It seems like what you really mean is that this is an object
that is capable of having a RenderLayer backing it. I think your name should
simply reflect "capable of having a RenderLayer" and that it should not be
using one specific feature of RenderLayers (that they are transformable).

I'd suggest RenderLayerModelObject, since what you really mean is a
RenderObject that participates in the RenderLayer way of doing things.

Also, I'm not too happy with the generic rename to "updateFromStyle", but I
don't really have a better suggestion.